Skip to content

Minor correction to demo transformer script #21033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 8, 2025
Merged

Minor correction to demo transformer script #21033

merged 6 commits into from
Aug 8, 2025

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Aug 6, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #20920

Fix conceptual problem in demo script. Code would run fine as is, but currently the model would be able to cheat by attending to future tokens. Essentially, there is missing a masking in the input tensor. This is also present in the original implementation which this script is adapted from:
https://github.com/pytorch/examples/blob/5a4ca9269f689acfc8fcf2118bcb27470e28dd2f/word_language_model/model.py#L131-L138

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21033.org.readthedocs.build/en/21033/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 6, 2025
@Borda Borda merged commit bcfa4dd into Lightning-AI:master Aug 8, 2025
84 checks passed
Borda pushed a commit that referenced this pull request Aug 13, 2025
@SkafteNicki @Borda
Minor correction to demo transformer script (#21033)
be290d6 
* fix demo transformer
* fix typing

(cherry picked from commit bcfa4dd)
Borda pushed a commit that referenced this pull request Aug 13, 2025
@SkafteNicki @Borda
Minor correction to demo transformer script (#21033)
e1f0175 
* fix demo transformer
* fix typing

(cherry picked from commit bcfa4dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code issue in demo

3 participants

@SkafteNicki @Borda @justusschock